Repository navigation
Run the chat-app Web smoke in Safari and Firefox and add a WebGPU generation E2E (#1025) - #2002
Merged
Merged
Conversation
…eration E2E (#1025) --browser safari|firefox serves require-corp and drives the real-model smoke through safaridriver or geckodriver; --backend webgpu offloads all layers. The Dart web scenarios reject both browsers: package:test pages are never cross-origin isolated. web-webgpu-generation compares full-offload WebGPU text with CPU Wasm in direct and worker runtimes.
…the page world (#1025) Safari and Firefox now run the GPU-active probe; a CPU-labelled run fails. Firefox page-state reads run as page <script> elements like the init script. The Firefox matrix row is marked unqualified until a real run passes.
This was referenced Nov 14, 2026
Closed
leehack
marked this pull request as ready for review
November 14, 2026 03:00
Contributor
|
Chat app preview removed for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_local_e2e.dart --scenario chat-app-web-real-model-smoke --browser safari|firefoxserves the repo with--coep require-corpand drives the smoke through safaridriver or geckodriver (FIREFOX_EXECUTABLE,GECKODRIVER).--backend webgpupasses--backend-index 0 --gpu-layers 99(default stays CPU Wasm).--browser safari|firefox: package:test pages are never cross-origin isolated.web-webgpu-generationscenario andtest/e2e/webgpu/webgpu_generation_e2e_test.dart(local-only): full-offload WebGPU text vs CPU Wasm, direct and worker.<script>because geckodriver's execute sandbox hides page globals.--backend webgpunow also passes--expect-gpu-active true(a CPU fallback fails) and, with--backend, onlycpuorwebgpuare accepted by this scenario (stricter allowlist);--backend webgpuis rejected on other scenarios. Safari and Firefox run Gate Web ASR runtime and microphone lifecycle in the harness (#329) #1999's runtime probe.Production-readiness scope
lib/change.Completeness checklist
PR type guidance
Test Plan
dart run tool/prepare_workspace.dartdart format --output=none --set-exit-if-changed .dart analyzedart test -p vm test/unit/tooling/(1830 passed); full-j 1VM and Chrome suites left to CIcoverage-lib: N/A, nolib/change--coep require-corpfails the dry-run and matrix tests); real runs belowMatrix Evidence
web-real-model-smoke-safariweb-real-model-smoke-safari--backend webgpu(requests 99 layers; Qwen3.5-0.8B is capped at 2, so partial offload)web-real-model-smoke-safari--backend webgpu --expect-gpu-active true, stories15M,--allow-any-responseweb-real-model-smoke-firefoxweb-webgpu-generationReview Notes
High-risk regression review